This repository has been archived by the owner on Feb 22, 2024. It is now read-only.
Customizable send_mail #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2017
jirikuncar
reviewed
Nov 6, 2017
docs/customizing.rst
Outdated
|
|
||
| return app | ||
|
|
||
| Note that the above ``security.send_mail_task`` override will be useless if you |
There was a problem hiding this comment.
Have you consider using .. note:: directive http://www.sphinx-doc.org/en/stable/markup/para.html#directive-note ?
jirikuncar
reviewed
Nov 6, 2017
docs/customizing.rst
Outdated
| app.config.from_object(config) | ||
|
|
||
| def custom_send_mail(subject, recipient, template, **context): | ||
| # implement your own logic here |
There was a problem hiding this comment.
can you add an example when it would be necessary to override the send_mail method?
|
@jirikuncar I added an example. I hope it does not feel too contrived. My real world use case is too complex to be suitable for an example. |
jirikuncar
reviewed
Nov 6, 2017
docs/customizing.rst
Outdated
|
|
||
| from flask import Flask | ||
| from flask_security import Security, SQLAlchemyUserDatastore | ||
| from flask.ext.emails import Message |
jirikuncar
approved these changes
Nov 6, 2017
|
Thought I'd mention that I personally have been using this branch of It seems to me that |
jwag956
referenced
this pull request
in Flask-Middleware/flask-security
May 7, 2019
* Make send_mail function customizable.
jwag956
referenced
this pull request
in Flask-Middleware/flask-security
May 7, 2019
* Customizable send_mail (#730) * Make send_mail function customizable. * Modified original commit to set send_mail and render_template as init configurations. This is easier than subclassing Security and is the same as other overrides such as login_manager. Updated docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pretty straightforward PR lets you override the
send_mailmethod with your own logic. The override method is similar torender_template.Thanks for considering this!