Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wekzeug 1.0 compatibility #114

Merged
merged 3 commits into from
May 14, 2020
Merged

Fix wekzeug 1.0 compatibility #114

merged 3 commits into from
May 14, 2020

Conversation

SqrtMinusOne
Copy link
Contributor

werkzeug.contrib.cache was moved to https://github.com/pallets/cachelib since version 1.0

@SqrtMinusOne SqrtMinusOne mentioned this pull request Feb 16, 2020
Closed
@rayluo rayluo mentioned this pull request Feb 18, 2020
Closed
@adeedchoudhury
Copy link

Any update on when this will be merged @SqrtMinusOne ? Thanks!

@SqrtMinusOne
Copy link
Contributor Author

I have no idea; addressing that to @fengsp.
As for now, as the module isn't complicated, I'd suggest taking the parts you need.

@rayluo
Copy link
Contributor

rayluo commented Mar 28, 2020 •
edited
Loading

FYI: I encounter same problem, and I fixed it in my fork, and you can install it in this way:

pip install git+https://github.com/rayluo/flask-session.git@0.3.x

@m1waterman88
Copy link

Had the issue causing this PR. Can confirm this PR update fixed the issue for me when manually updating flask_session/sessions.py

@rayluo
Copy link
Contributor

rayluo commented Mar 29, 2020

@m1waterman88 Would you mind also try out pip install git+https://github.com/rayluo/flask-session.git@0.3.x to see if it can fix the issue for you WITHOUT needing to manually update the file?

@m1waterman88
Copy link

@m1waterman88 Would you mind also try out pip install git+https://github.com/rayluo/flask-session.git@0.3.x to see if it can fix the issue for you WITHOUT needing to manually update the file?

Since you made the same code change that this PR request has (and thus that I have), yes, it would fix it.

@changning-niu changning-niu mentioned this pull request Apr 6, 2020
Closed
@tvb
Copy link

tvb commented Apr 13, 2020 •
edited
Loading

pip install git+https://github.com/rayluo/flask-session.git@0.3.x

I can confirm this fixed it for me too. (using pip3)

@m1waterman88
Copy link

I've reached out to to repo owner twice via email in addition to any actions in the Flask-Session repo, and I haven't received a reply. Between the lack of response and the last commit occurring on Feb 9, 2017, unfortunately I think this repo has been abandoned.

@tvb
Copy link

tvb commented Apr 14, 2020

@m1waterman88 I hate it when this happens. Great software gets abandoned at some point and is turning into waste over time. What are our alternatives for flask-session?

OrkoHunter added a commit to pep8speaks-org/pep8speaks that referenced this pull request Apr 28, 2020
@OrkoHunter
Deprecare Flask-Session to fix master build
5c7d1ca 
The dependency flask-session is broken because of a change pallets-eco/flask-session#114. Unfortunately, months have passed
but no action has been taken to merge the fix.

PEP8Speaks does not really need Flask-Session and hence, it is better to remove it.
@OrkoHunter OrkoHunter mentioned this pull request Apr 28, 2020
Merged
@m1waterman88
Copy link

@fengsp, please provide write access so we can keep this repo going. Many use it and would like to continue to do so.

image

We can fork it, sure, but it's easier for projects already routing to this repo to continue to do so.

Thanks.

@fengsp fengsp merged commit a57d784 into pallets-eco:master May 14, 2020
@rayluo
Copy link
Contributor

rayluo commented May 14, 2020

Welcome back, @fengsp ! :-D Please release this into 0.3.2 soon!

@tvb
Copy link

tvb commented May 14, 2020

😱

@jamadden jamadden mentioned this pull request Nov 11, 2020
Closed
@pguerin3 pguerin3 mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1waterman88 m1waterman88 m1waterman88 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SqrtMinusOne @adeedchoudhury @rayluo @m1waterman88 @tvb @fengsp