Little problem with the type hint

[Zoupers]

sqlalchemy does not exporse orm as a clear attr, so the type hint there is not working.
now we change that to this with full path.

And it works out with the type hint.

The main problem with that might be the use of some thing like db.session, which I use a lot in project to do CRUD operations. Previously we have that. It will stock since sa don't have orm attr. It's a module.

flask-sqlalchemy/src/flask_sqlalchemy/extension.py

Line 325 in d137db1

) -> sa.orm.scoped_session[Session]:

And I think we should make this little change to provide more type hint info.

Environment:

• Python version: 3.9.16
• Flask-SQLAlchemy version: 3.0.3
• SQLAlchemy version: 2.0.0 and above

[davidism]

It's a bug with pyright: microsoft/pyright#3884. I'm willing to take the suggested fix of import sqlalchemy.orm as sa_orm.

[Zoupers]

It't not only sa.orm, but also sa.exc and sa.event. But they can adopt the rule to be like sa_exc and sa_event. OK?

[davidism]

Yes, that's what I meant.

[pamelafox]

Fixed in 3.0.4 which is now released. Thanks for the PR!