Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1205 #1206

Closed
wants to merge 2 commits into from
Closed

Fix #1205 #1206

wants to merge 2 commits into from

Conversation

Zoupers
Copy link
Contributor

@Zoupers Zoupers commented May 6, 2023

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@Zoupers
Copy link
Contributor Author

Zoupers commented May 6, 2023

Delete line means I think there is no need to do that.

@Zoupers Zoupers changed the title 3.0.x Fix #1205 May 6, 2023
@davidism
Copy link
Member

davidism commented May 6, 2023

Thanks, but this has a lot of changes that aren't related to the issue, and I'd rather use import sqlalchemy.orm as sa_orm.

@davidism davidism closed this May 6, 2023
@davidism
Copy link
Member

davidism commented May 6, 2023

Also, when opening a pull request, make sure to create a new branch for your work, and give the PR a descriptive title.

@Zoupers
Copy link
Contributor Author

Zoupers commented May 6, 2023

@davidism The changes that not related to the issue, means the test and ?

@davidism
Copy link
Member

davidism commented May 6, 2023

The change to cli.py, just leave that as it currently is.

@Zoupers
Copy link
Contributor Author

Zoupers commented May 6, 2023

The change to cli.py, just leave that as it currently is.

OK. I will do it now.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants