show errors on multiple instances or missing init #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidism
force-pushed
the
instance-errors
branch
from
c1554f2
to
182ba62
Compare
cjmayo
added a commit
to cjmayo/flask-admin
that referenced
this pull request
Jan 28, 2023
As described in: https://flask-sqlalchemy.palletsprojects.com/en/3.0.x/quickstart/#configure-the-extension Was only working by accident prior to Flask-SQLAlchemy 3: pallets-eco/flask-sqlalchemy#1151
cjmayo
added a commit
to cjmayo/flask-admin
that referenced
this pull request
Jan 28, 2023
As described in: https://flask-sqlalchemy.palletsprojects.com/en/3.0.x/quickstart/#configure-the-extension Was only working by accident prior to Flask-SQLAlchemy 3: pallets-eco/flask-sqlalchemy#1151
cjmayo
added a commit
to cjmayo/flask-admin
that referenced
this pull request
Jan 28, 2023
As described in: https://flask-sqlalchemy.palletsprojects.com/en/3.0.x/quickstart/#configure-the-extension Was only working by accident prior to Flask-SQLAlchemy 3: pallets-eco/flask-sqlalchemy#1151 Revealed problem with geoa tests creating tables twice outside of an application context.
cjmayo
added a commit
to cjmayo/flask-admin
that referenced
this pull request
Jan 30, 2023
As described in: https://flask-sqlalchemy.palletsprojects.com/en/3.0.x/quickstart/#configure-the-extension Was only working by accident prior to Flask-SQLAlchemy 3: pallets-eco/flask-sqlalchemy#1151 Revealed that geoa tests were creating tables twice outside of an application context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show an error for an invalid pattern which worked by accident but stopped in version 3. The user creates multiple extension instances, usually in different modules or during tests, rather than importing a single instance. If they fail to call
init_appon one, the extension can't find the app in its engine registry. Or if they callinit_appon both they can end up with conflicting sessions.