Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing base class in reflection docs, adding to reflection test #1283

Merged
merged 5 commits into from Jan 15, 2024

Conversation

pamelafox
Copy link
Contributor

This PR adds "(db.Model)" to reflection docs example. I also added to the reflection test to mirror the documentation example, and I put an additional example in the docs showing default bind key.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
    - [ ] Add an entry in CHANGES.rst summarizing the change and linking to the issue.
    - [ ] Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@pamelafox pamelafox changed the base branch from main to 3.1.x November 25, 2023 15:05
@pamelafox
Copy link
Contributor Author

The typing test is now passing, though I'm confused as to why it was previously failing. Seems like it must be cache related since I can't replicate locally, but I also haven't clearly proved it was cache related. Anyway, passing now.

@pamelafox pamelafox merged commit 3ecd038 into 3.1.x Jan 15, 2024
8 checks passed
@pamelafox pamelafox deleted the reflect-docs branch January 15, 2024 15:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect(?) example in documentation
2 participants