added as_dict method for Pagination class

[kalombos]

#482

[davidism]

I'm worried about returning items in the dict. Since the use of this method is for generating a JSON response, this implies that the items will be JSON serializable, a guarantee that we do not make.

[kalombos]

I've fixed code style but i don't know what to do with items. Just remove it from dictionary?

[italomaia]

@kalombos if items always have to be properly parsed (meaning set again in the dictionary), then it probably makes sense to not have it in the output of to_dict. Example:

page = query.paginate()
result = page.to_dict()
result['items'] = schema.dump(page)

This syntax would also be quite nice:

page = query.paginate()
result = page.to_dict(schema.dump)

[davidism]

Need to mention that the result of this will probably not be directly JSON serializable. To serialize query results and models, the dev will need to implement a custom Flask.json_encoder class.

[davidism]

Hi, thanks for working on this! Based on further discussion in #482, I no longer think this is a feature we want to support right now, so I'm going to close it.