Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like black 22.1.0 does not work with click 8.1.0 #2228

Closed
portante opened this issue Mar 28, 2022 · 1 comment
Closed

Looks like black 22.1.0 does not work with click 8.1.0 #2228

portante opened this issue Mar 28, 2022 · 1 comment

Comments

@portante
Copy link

In our CI jobs (see PR distributed-system-analysis/pbench#2715), they fail with the following:

py run-test: commands[0] | black --check .
Traceback (most recent call last):
  File "/var/tmp/jenkins/tox/py/bin/black", line 8, in <module>
    sys.exit(patched_main())
  File "src/black/__init__.py", line 1423, in patched_main
  File "src/black/__init__.py", line 1409, in patch_click
ImportError: cannot import name '_unicodefun' from 'click' (/var/tmp/jenkins/tox/py/lib/python3.9/site-packages/click/__init__.py)
ERROR: InvocationError for command /var/tmp/jenkins/tox/py/bin/black --check . (exited with code 1)

Run black 22.1.0 with click 8.1.0.

black 22.1.0 should work with click.

Environment:

  • Python version: Python 3.9
  • Click version: 8.1.0
@portante
Copy link
Author

Never mind. black has already fixed the problem with 22.3.0.

shapiromatron added a commit to shapiromatron/bmds that referenced this issue Apr 7, 2022
shapiromatron added a commit to shapiromatron/bmds that referenced this issue Apr 7, 2022
* simple dll load test

* pin click; pallets/click#2228, fix when update black

* update black to stable version

* remove click
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant