Fix group overload

[layday]

Additional fixes for #2558 building on @Tinche's PR :)

---

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• Add or update relevant docs, in the docs folder and in code.
• Add an entry in CHANGES.rst summarizing the change and linking to the issue.
• Add .. versionchanged:: entries in any relevant code docs.
• Run pre-commit hooks and fix any issues.
• Run pytest and tox, no tests failed.

[Tinche]

Out of curiosity, what does strict mode do for pyright?

[layday]

It turns on these additional checks. In my experience Pyright won't error for type vars it's not able to solve with default settings. The group overload error would've been caught by the assert, but there might be auxiliary errors we are not explicitly testing against that strict mode might be able to detect.

[Tinche]

Cool, thanks. What's the default type checking mode? It's not off I hope

Edit: it's basic, found it in the docs finally

[ofek]

While you are fixing things, does this look like a bug? #2558 (comment)

Your change fixes the issue actually, thanks! #2558 (comment)

[Tinche]

LGTM FWIW. Might want to add a changelog entry.

[alex]

Will this resolve the typing of:

@click.group()
def cli():
    pass


@cli.command()
@click.argument("version")
def release(version: str) -> None:
    # ...

or is this a distinct issue?

[layday]

That doesn't produce an error for me. Have you tried with click 8.1.5? Fixed by this PR.

[davidism]

Click 8.1.6 released.