Detect a Windows console handle correctly using GetConsoleMode #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isatty returns True for the NUL device on Windows. So use GetConsoleMode instead to detect a console handle. See https://bugs.python.org/issue28654 Fixes pallets#1065
davidism
force-pushed
the
winconsole-detection-bug
branch
from
76dbf0a
to
3f49ec2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isattyreturnsTruefor theNULdevice on Windows. So useGetConsoleModeinstead to detect a console handle.See https://bugs.python.org/issue28654
Fixes #1065
@uranusjr Feel free to test if this fixes your issue