enable colored output on jupyter notebooks #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the callout i started for this wrt windows was timed rather badly, i'll take a look at making a unix only fix soon |
RonnyPfannschmidt
force-pushed
the
jupyter-notebook
branch
from
5d9b299
to
d2fa1f2
Compare
RonnyPfannschmidt
changed the title
|
i added a basic cheapskate test for detecting jupyter on unix and marked it as xfail on windows until someone with a system comes along to fix/test the detection opts out on windows |
RonnyPfannschmidt
force-pushed
the
jupyter-notebook
branch
from
d2fa1f2
to
0c848e8
Compare
davidism
approved these changes
Jan 15, 2019
This doesn't support Windows since I don't have a system where I could check/test/automate colorama support. fixes pallets#1185
davidism
force-pushed
the
jupyter-notebook
branch
from
0c848e8
to
06d0308
Compare
|
#1271 Applies specifically to Jupyter Lab (in case there's a difference in this case from the workings of Jupyter Notebook). Also: # Doing:
print(click.style(text, **styles), file=file)
# works (prints styled), while this doesn't (prints unstyled):
click.echo(click.style(text, **styles), file=file) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this currently lacks automated tests and is entirely untested on windows
fixes #1185