Types: don't leave generic types without a parameter

[mjpieters]

Enable disallow_any_generics and provide type information for missing parameters for type hints.

• fixes Type hints: public API uses generic hints without parameters #2398

Checklist:

• Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
• Add or update relevant docs, in the docs folder and in code.
• Add an entry in CHANGES.rst summarizing the change and linking to the issue.
• Add .. versionchanged:: entries in any relevant code docs.
• Run pre-commit hooks and fix any issues.
• Run pytest and tox, no tests failed.

[davidism]

I'm really interested in the patterns you used for decorators by using ParamSpec. It's clearly a more sophisticated pattern than the one mypy documents. Is there anywhere I can read more about it?

[davidism]

Also, I usually consider typing changes bug fixes, so you can retarget this to 8.1.x (although I may just make the next release 8.2 anyway).

[mjpieters]

I'm really interested in the patterns you used for decorators by using ParamSpec. It's clearly a more sophisticated pattern than the one mypy documents. Is there anywhere I can read more about it?

Sure: ParamSpec and Concatenate are defined in PEP 612 – Parameter Specification Variables.

[mjpieters]

Also, I usually consider typing changes bug fixes, so you can retarget this to 8.1.x (although I may just make the next release 8.2 anyway).

I wasn't aware I targeted anything :-D I found the Version 8.2.0 -- Unreleased section and put my comment there. Should I inject a Version 8.1.4 -- Unreleased section, should I replace 8.2.0 with 8.1.4, or what?

[davidism]

You can rebase to the 8.1.x branch then change the PR target. Yeah, just add a section for another unreleased version, or I can handle the changelog.

[mjpieters]

You can rebase to the 8.1.x branch then change the PR target. Yeah, just add a section for another unreleased version, or I can handle the changelog.

Check, done.

It's better to change the PR target first and then push a rebased set of commits, as the github checks won't be re-run on a PR target change. I had to force a new commit SHA so I could force-push again and trigger the pipeline. ;-)

[coloursofnoise]

Having the ParamSpec type hint on decorators like pass_context is a very welcome change, since it helps to enforce the correct number of arguments in the command callback function.

I'm currently doing this as part of my unit tests, but I was also looking into creating a PR similar to this one before I saw it already exists. I will definitely be testing this PR in development going forward.