Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix zsh completion loaded from fpath #2544

Merged
merged 1 commit into from Jun 30, 2023
Merged

fix zsh completion loaded from fpath #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Expand Up @@ -17,6 +17,7 @@ Unreleased
- Improve responsiveness of ``click.clear()``. :issue:`2284`
- Improve command name detection when using Shiv or PEX. :issue:`2332`
- Avoid showing empty lines if command help text is empty. :issue:`2368`
- ZSH completion script works when loaded from ``fpath``. :issue:`2344`.


Version 8.1.3
Expand Down
8 changes: 7 additions & 1 deletion src/click/shell_completion.py
View file
Open in desktop
Expand Up @@ -157,7 +157,13 @@ def __getattr__(self, name: str) -> t.Any:
fi
}

compdef %(complete_func)s %(prog_name)s;
if [[ $zsh_eval_context[-1] == loadautofunc ]]; then
# autoload from fpath, call function directly
%(complete_func)s "$@"
else
# eval/source/. command, register function for later
compdef %(complete_func)s %(prog_name)s
fi
"""

_SOURCE_FISH = """\
Expand Down