Skip to content

Commit

Permalink
Change cli.py file for bad if/elif statement and add testing in test_…
Browse files Browse the repository at this point in the history
…cli.py for prepare_exec_for_file
  • Loading branch information
jphilipsen05 committed Jun 2, 2016
1 parent 41f3d67 commit 2e0d78a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
6 changes: 3 additions & 3 deletions flask/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ def prepare_exec_for_file(filename):
module = []

# Chop off file extensions or package markers
if filename.endswith('.py'):
filename = filename[:-3]
elif os.path.split(filename)[1] == '__init__.py':
if os.path.split(filename)[1] == '__init__.py':
filename = os.path.dirname(filename)
elif filename.endswith('.py'):
filename = filename[:-3]
else:
raise NoAppException('The file provided (%s) does exist but is not a '
'valid Python file. This means that it cannot '
Expand Down
9 changes: 8 additions & 1 deletion tests/test_cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from flask import Flask, current_app

from flask.cli import AppGroup, FlaskGroup, NoAppException, ScriptInfo, \
find_best_app, locate_app, with_appcontext
find_best_app, locate_app, with_appcontext, prepare_exec_for_file


def test_cli_name(test_apps):
Expand Down Expand Up @@ -49,6 +49,13 @@ class mod:
pytest.raises(NoAppException, find_best_app, mod)


def test_prepare_exec_for_file(test_apps):
assert prepare_exec_for_file('test.py') == 'test'
assert prepare_exec_for_file('/usr/share/__init__.py') == 'share'
with pytest.raises(NoAppException):
prepare_exec_for_file('test.txt')


def test_locate_app(test_apps):
"""Test of locate_app."""
assert locate_app("cliapp.app").name == "testapp"
Expand Down

0 comments on commit 2e0d78a

Please sign in to comment.