Skip to content

Commit

Permalink
Close tag on js examples.
Browse files Browse the repository at this point in the history
  • Loading branch information
lepture committed Apr 21, 2018
1 parent 93698b5 commit b7f6ff4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion examples/javascript/js_example/templates/base.html
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@
#result { font-weight: bold; }
</style>
<ul>
<li><span>Type:</span>
<li><span>Type:</span></li>
<li class="{% if js == 'plain' %}active{% endif %}">
<a href="{{ url_for('index', js='plain') }}">Plain</a>
</li>
<li class="{% if js == 'fetch' %}active{% endif %}">
<a href="{{ url_for('index', js='fetch') }}">Fetch</a>
</li>
<li class="{% if js == 'jquery' %}active{% endif %}">
<a href="{{ url_for('index', js='jquery') }}">jQuery</a>
</li>
</ul>
<hr>
<p>{% block intro %}{% endblock %}</p>
Expand Down

4 comments on commit b7f6ff4

@davidism
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you revert this? Our policy is to not use optional close tags in HTML files.

@lepture
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think it is optional close tags.

Tags like this <hr /> -> <hr> are optional.

@lepture
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidism I reverted it.

@davidism
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.