Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Werkzeug's JSON mixin #3125

Closed
davidism opened this issue Mar 20, 2019 · 3 comments
Closed

Use Werkzeug's JSON mixin #3125

davidism opened this issue Mar 20, 2019 · 3 comments
Labels
Milestone

Comments

@davidism
Copy link
Member

@davidism davidism commented Mar 20, 2019

pallets/werkzeug#1445 moved Flask's JSONMixin to Werkzeug. Flask should now use Werkzeug's version, with some overrides. Will need to bump minimum Werkzeug version.

@davidism davidism added the json label Mar 20, 2019
@davidism davidism added this to the 1.1 milestone Mar 20, 2019
@PyDever
Copy link

@PyDever PyDever commented Mar 29, 2019

Why are you wanting to use that API instead of using the default standard library JSON parsing mechanism.

Loading

@jamespic
Copy link

@jamespic jamespic commented Apr 11, 2019

@PyDever The standard library json module didn't handle binary data (i.e, the data that comes into Flask over the network) properly until Python 3.6, so some additional handling is required for that. You also have issues with CSRF if you use the standard library json code naïvely.

Loading

@seawolf42
Copy link
Contributor

@seawolf42 seawolf42 commented May 6, 2019

starting to work on this

EDITED: being worked on by @EtiennePelletier

Loading

EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
davidism added a commit to EtiennePelletier/flask that referenced this issue May 19, 2019
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
davidism added a commit to EtiennePelletier/flask that referenced this issue May 19, 2019
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants