Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Werkzeug's JSON mixin #3125

Closed
davidism opened this issue Mar 20, 2019 · 3 comments · Fixed by #3181
Closed

Use Werkzeug's JSON mixin #3125

davidism opened this issue Mar 20, 2019 · 3 comments · Fixed by #3181
Labels
json
Milestone
1.1.0

Comments

@davidism
Copy link
Member

pallets/werkzeug#1445 moved Flask's JSONMixin to Werkzeug. Flask should now use Werkzeug's version, with some overrides. Will need to bump minimum Werkzeug version.
@davidism davidism added the json label Mar 20, 2019
@davidism davidism added this to the 1.1 milestone Mar 20, 2019
@PyDever
Copy link

PyDever commented Mar 29, 2019

Why are you wanting to use that API instead of using the default standard library JSON parsing mechanism.

@jamespic
Copy link

@PyDever The standard library json module didn't handle binary data (i.e, the data that comes into Flask over the network) properly until Python 3.6, so some additional handling is required for that. You also have issues with CSRF if you use the standard library json code naïvely.

@seawolf42
Copy link
Contributor

seawolf42 commented May 6, 2019 •
edited
Loading

starting to work on this

EDITED: being worked on by @EtiennePelletier

EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
@EtiennePelletier
pallets#3125 - Use Werkzeug's JSONMixin class (moved from Flask) and …
0dea7fc 
…update tests
EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
@EtiennePelletier
Fix pallets#3125 - Use Werkzeug's JSONMixin class (moved from Flask) …
680352d 
…and update tests
@EtiennePelletier EtiennePelletier mentioned this issue May 6, 2019
Merged
EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019
@EtiennePelletier
Use Werkzeug's JSONMixin class and update tests
7f9c496 
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
davidism pushed a commit to EtiennePelletier/flask that referenced this issue May 19, 2019
@EtiennePelletier @davidism
Use Werkzeug's JSONMixin class and update tests
a3f4891 
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
davidism pushed a commit to EtiennePelletier/flask that referenced this issue May 19, 2019
@EtiennePelletier @davidism
Use Werkzeug's JSONMixin class and update tests
8129f5c 
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
json
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Use Werkzeug's JSONMixin class (moved from Flask) and update tests EtiennePelletier/flask
4 participants
@jamespic @davidism @seawolf42 @PyDever