Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Werkzeug's JSON mixin #3125

Closed
davidism opened this issue Mar 20, 2019 · 3 comments

Comments

@davidism
Copy link
Member

commented Mar 20, 2019

pallets/werkzeug#1445 moved Flask's JSONMixin to Werkzeug. Flask should now use Werkzeug's version, with some overrides. Will need to bump minimum Werkzeug version.

@davidism davidism added the json label Mar 20, 2019

@davidism davidism added this to the 1.1 milestone Mar 20, 2019

@PyDever

This comment has been minimized.

Copy link

commented Mar 29, 2019

Why are you wanting to use that API instead of using the default standard library JSON parsing mechanism.

@jamespic

This comment has been minimized.

Copy link

commented Apr 11, 2019

@PyDever The standard library json module didn't handle binary data (i.e, the data that comes into Flask over the network) properly until Python 3.6, so some additional handling is required for that. You also have issues with CSRF if you use the standard library json code naïvely.

@seawolf42

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

starting to work on this

EDITED: being worked on by @EtiennePelletier

EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019

EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019

EtiennePelletier added a commit to EtiennePelletier/flask that referenced this issue May 6, 2019

Use Werkzeug's JSONMixin class and update tests
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15

davidism added a commit to EtiennePelletier/flask that referenced this issue May 19, 2019

Use Werkzeug's JSONMixin class and update tests
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15

davidism added a commit to EtiennePelletier/flask that referenced this issue May 19, 2019

Use Werkzeug's JSONMixin class and update tests
Fixes pallets#3125
Flask's JSONMixin class was moved to Werkzeug>=0.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.