Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of Werkzeug is not compatible with Flask #3486

Closed
andresionek91 opened this issue Feb 7, 2020 · 4 comments
Closed

New version of Werkzeug is not compatible with Flask #3486

andresionek91 opened this issue Feb 7, 2020 · 4 comments

Comments

@andresionek91
Copy link

andresionek91 commented Feb 7, 2020 •
edited
Loading

Expected Behavior

A new major release of Werkzeug is available as of yesterday. https://pypi.org/project/Werkzeug/1.0.0/

This is not compatible with flask_admin and flask_wtf:

File "/home/airflow/miniconda/envs/conda_env/lib/python3.6/site-packages/flask_admin/model/base.py", line 8, in <module> from werkzeug import secure_filename ImportError: cannot import name 'secure_filename'

Pinning Werkzeug to version 0.16.1 should solve the issue. https://github.com/pallets/flask/blob/master/setup.py#L56

Flask Version: 1.0.4
@andresionek91 andresionek91 changed the title New version of Werkzeug is not compatible with flask New version of Werkzeug is not compatible with Flask Feb 7, 2020
This was referenced Feb 7, 2020
Closed
Closed
@DavidHernandez
Copy link

I've created a PR with the proposed solution of @andresionek91 to see if that solves the issue, as a previous step before adapting the Flask code to use the new version of Werkzeug.

@ThiefMaster
Copy link
Member

flask-admin is not part of flask but a third-party extension module.

@DavidHernandez
Copy link

@ThiefMaster Werkzeug is a dependency of Flask and it also breaks Flask, not only flask_admin or flask_wtf.

@ThiefMaster
Copy link
Member

I still haven't seen a traceback where it broke flask itself...

@gricey432 gricey432 mentioned this issue Feb 10, 2020
Closed
HusseinKabbout referenced this issue in qwc-services/qwc-config-service Feb 10, 2020
@HusseinKabbout
Update requirements.txt
bb92171
HusseinKabbout referenced this issue in qwc-services/qwc-db-auth Feb 10, 2020
@HusseinKabbout
Update requirements.txt
d0e883f
HusseinKabbout added a commit to qwc-services/qwc-ogc-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
6170f76 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-data-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
71bfc4d 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-elevation-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
e28b08f 
Downgrade werkzeug, because the newest release breaks Flask and flask-restplus. More information --> pallets/flask#3486
HusseinKabbout added a commit to qwc-services/qwc-admin-gui that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
00f9156 
Downgrade werkzeug, because the newest release breaks Flask. More information --> pallets/flask#3486
HusseinKabbout added a commit to qwc-services/qwc-map-viewer that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
5c3ba3f 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-permalink-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
497e0bd 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-fulltext-search-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
d9fc521 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-print-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
a38a7b7 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to qwc-services/qwc-ldap-auth that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
6cfcd7f 
Downgrade werkzeug, because the newest release breaks Flask. More information --> pallets/flask#3486
HusseinKabbout added a commit to qwc-services/qwc-registration-gui that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
57ae2d9 
Downgrade werkzeug, because the newest release breaks Flask. More information --> pallets/flask#3486
HusseinKabbout added a commit to qwc-services/qwc-legend-service that referenced this issue Feb 10, 2020
@HusseinKabbout
Update requirements because of broken package
3db98e7 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
HusseinKabbout added a commit to HusseinKabbout/qwc-map-viewer that referenced this issue Feb 11, 2020
@HusseinKabbout
Update requirements because of broken package
68d6dbd 
Downgrade werkzeug and jsonschema, because their newest release break Flask and flask-restplus. More information --> pallets/flask#3486 and noirbizarre/flask-restplus#777
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forces specific version of Werkzeug to prevent breaking Flask DavidHernandez/flask
3 participants
@ThiefMaster @DavidHernandez @andresionek91