Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simplejson #3555

Closed
davidism opened this issue Apr 4, 2020 · 5 comments · Fixed by #3562
Closed

Remove simplejson #3555

davidism opened this issue Apr 4, 2020 · 5 comments · Fixed by #3562
Assignees
@davidism
Labels
json
Milestone
2.0.0

Comments

@davidism
Copy link
Member

davidism commented Apr 4, 2020

In modern Python it's unlikely to be significantly better than the built-in json. The module used by JSONMixin is overridable, so users can plug it in again if they want.

See pallets/itsdangerous#146 and pallets/werkzeug#1766.
@davidism davidism added this to the 2.0.0 milestone Apr 4, 2020
@davidism davidism self-assigned this Apr 4, 2020
@owaiskazi19

This comment has been minimized.

Sign in to view
@davidism

This comment has been minimized.

Sign in to view
@owaiskazi19

This comment has been minimized.

Sign in to view
@davidism davidism mentioned this issue Apr 7, 2020
Merged
@davidism davidism added the json label Apr 7, 2020
@svidela
Copy link

svidela commented May 28, 2020

Hi,

I'm relying on simplejson to serialize decimal.Decimal objects when calling to jsonify. In fact, jsonify it's called by flask-smorest which I'm using for building my API. What would be the recommended way (if any) to force jsonify to keep using simplejson?

Regards,

@davidism
Copy link
Member Author 

from simplejson import JSONEncoder

app.json_encoder = JSONEncoder

@davidism davidism mentioned this issue Oct 3, 2020
Closed
@pallets pallets locked as resolved and limited conversation to collaborators Oct 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidism davidism

Labels
json
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Remove simplejson and deprecate encoding options pallets/flask
3 participants
@svidela @davidism @owaiskazi19