remove simplejson #1766
Merged
remove simplejson #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In modern Python it's unlikely to be significantly better than the built-in json module. The module used by JSONMixin is overridable, so users can plug it in if they want. See pallets/itsdangerous#146
|
Will this be a BC break as simplejson takes bytes as keys and the built-in json does not? |
|
I had no idea simplejson did that. Wasn't the whole point of simplejson that it behaved like json? :-( This is slated for 2.0, so I'm fine with it. If a project needs bytes keys and doesn't want to encode their data (which they should anyway since otherwise it's relying on the system encoding), they can do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In modern Python it's unlikely to be significantly better than the built-in
json. The module used byJSONMixinis overridable, so users can plug it in again if they want.See pallets/itsdangerous#146