Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove simplejson #1766

Merged
merged 1 commit into from Mar 19, 2020
Merged

remove simplejson #1766

merged 1 commit into from Mar 19, 2020

Conversation

davidism
Copy link
Member

In modern Python it's unlikely to be significantly better than the built-in json. The module used by JSONMixin is overridable, so users can plug it in again if they want.

See pallets/itsdangerous#146

In modern Python it's unlikely to be significantly better than the
built-in json module. The module used by JSONMixin is overridable, so
users can plug it in if they want.

See pallets/itsdangerous#146
@davidism davidism added this to the 2.0.0 milestone Mar 19, 2020
@davidism davidism merged commit 8a37c2f into master Mar 19, 2020
@davidism davidism deleted the remove-simplejson branch March 19, 2020 16:34
@aenglander
Copy link
Contributor

Will this be a BC break as simplejson takes bytes as keys and the built-in json does not?

@davidism
Copy link
Member Author

I had no idea simplejson did that. Wasn't the whole point of simplejson that it behaved like json? :-(

This is slated for 2.0, so I'm fine with it. If a project needs bytes keys and doesn't want to encode their data (which they should anyway since otherwise it's relying on the system encoding), they can do Request.json_module = simplejson (or wrap it a bit to support more types) and keep going.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants