Remove deprecated old module, and start deprecating request.json.
#1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are two different things. We can introduce deprecation warnings at any minor version IMO, but removing modules should be postponed to 1.0. |
|
Will next release be 0.11? |
|
Not sure. If we actually are going to skip 0.11, this PR would be fine, but @mitsuhiko has to decide this. |
|
OK, I ses. |
|
Actually i changed my mind on this: @methane could you resubmit the methods stuff, with testcase and changelog? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.jsonhas not deprecated explicitly with warning.So instead of removing it, start explicit deprecating.