Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing environ to test client #2412

Merged
merged 2 commits into from Jul 13, 2017
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 31 additions & 9 deletions flask/testing.py
Expand Up @@ -144,19 +144,41 @@ def session_transaction(self, *args, **kwargs):
self.cookie_jar.extract_wsgi(c.request.environ, headers)

def open(self, *args, **kwargs):
kwargs.setdefault('environ_overrides', {}) \
['flask._preserve_context'] = self.preserve_context
kwargs.setdefault('environ_base', self.environ_base)

as_tuple = kwargs.pop('as_tuple', False)
buffered = kwargs.pop('buffered', False)
follow_redirects = kwargs.pop('follow_redirects', False)
builder = make_test_environ_builder(self.application, *args, **kwargs)

return Client.open(self, builder,
as_tuple=as_tuple,
buffered=buffered,
follow_redirects=follow_redirects)
if (
not kwargs and len(args) == 1
and isinstance(args[0], (EnvironBuilder, dict))
):
environ = self.environ_base.copy()

if isinstance(args[0], EnvironBuilder):
environ.update(args[0].get_environ())
else:
environ.update(args[0])

environ['flask._preserve_context'] = self.preserve_context
else:
kwargs.setdefault('environ_overrides', {}) \
['flask._preserve_context'] = self.preserve_context
kwargs.setdefault('environ_base', self.environ_base)
builder = make_test_environ_builder(
self.application, *args, **kwargs
)

try:
environ = builder.get_environ()
finally:
builder.close()

return Client.open(
self, environ,
as_tuple=as_tuple,
buffered=buffered,
follow_redirects=follow_redirects
)

def __enter__(self):
if self.preserve_context:
Expand Down
18 changes: 18 additions & 0 deletions tests/test_testing.py
Expand Up @@ -15,6 +15,7 @@

from flask._compat import text_type
from flask.json import jsonify
from flask.testing import make_test_environ_builder


def test_environ_defaults_from_config(app, client):
Expand Down Expand Up @@ -74,6 +75,23 @@ def index():
assert flask.g.user_agent == 'Bar'


def test_client_open_environ(app, client, request):
@app.route('/index')
def index():
return flask.request.remote_addr

builder = make_test_environ_builder(app, path='/index', method='GET')
request.addfinalizer(builder.close)

rv = client.open(builder)
assert rv.data == b'127.0.0.1'

environ = builder.get_environ()
client.environ_base['REMOTE_ADDR'] = '127.0.0.2'
rv = client.open(environ)
assert rv.data == b'127.0.0.2'


def test_specify_url_scheme(app, client):
@app.route('/')
def index():
Expand Down