Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to not overwrite debug flag in cli #2765

Merged

Conversation

ThiefMaster
Copy link
Member

@ThiefMaster ThiefMaster commented May 8, 2018

This is intended for custom CLIs that may load a config file which already sets the debug flag and does not make use of the FLASK_* env vars at all.

Filed against 1,0-maintenance since this is functionality that was present before and was lost between 0.12 and 1.0.

@ThiefMaster ThiefMaster requested a review from davidism May 8, 2018 16:10
@ThiefMaster ThiefMaster changed the base branch from master to 1.0-maintenance May 8, 2018 16:10
ThiefMaster added a commit to indico/indico that referenced this pull request May 16, 2018
This reverts commit 79b1f7e.
Until pallets/flask#2765 is merged and in a released Flask version
This is mainly intended for custom CLIs that may load a config file
which already sets the debug flag and does not make use of the `FLASK_*`
env vars at all.
@ThiefMaster ThiefMaster merged commit 1a9caed into pallets:1.0-maintenance Jun 14, 2018
@ThiefMaster ThiefMaster deleted the custom-cli-ignore-debug branch June 14, 2018 11:31
@davidism davidism added this to the 1.0.3 milestone Jan 7, 2019
@davidism davidism added the cli label Jan 7, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants