Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect change in Gunicorn 20 #3421

Closed
wants to merge 6 commits into from
Closed

Update documentation to reflect change in Gunicorn 20 #3421

wants to merge 6 commits into from

Conversation

bilalshaikh42
Copy link

Gunicorn 20.0.0 no longer supports the factory pattern.
A simple change to the documentation will prevent users from trying this method

Here is the github issue regarding the change:
benoitc/gunicorn#2159

Bilal Shaikh added 3 commits November 11, 2019 17:40
Gunicorn 20.0.0 no longer supports the factory pattern. 
A simple change to the documentation will prevent users from trying this method 

Here is the github issue regarding the change:
benoitc/gunicorn#2159
Copy link
Member

@ThiefMaster ThiefMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you shouldn't have an app instance there, I'd rather use myproject.wsgi:app instead.

@ThiefMaster
Copy link
Member

also, I'd rather see gunicorn add explicit support for calling an app factory.

@bilalshaikh42
Copy link
Author

also, I'd rather see gunicorn add explicit support for calling an app factory.

I agree with this, but it seems as if the plan is to deprecate this feature.

@bilalshaikh42
Copy link
Author

you shouldn't have an app instance there, I'd rather use myproject.wsgi:app instead.

I can't get this pattern to work on my project. Setting a variable to equal the return of the app factory is working. How does the "wsgi" call fit in here?

@ThiefMaster
Copy link
Member

you add a wsgi.py that imports and calls your app factory

@tilgovi
Copy link

tilgovi commented Nov 12, 2019

I agree with the suggestions. Having a separate module that calls the factory and exposes the result is a good way to do this.

@tilgovi
Copy link

tilgovi commented Nov 12, 2019

Looks good to me.

@davidism
Copy link
Member

Given that benoitc/gunicorn#2178 is slated for 20.0.1 and adds this functionality back, I'm going to close this. Thanks for working on it.

@davidism davidism closed this Nov 19, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants