Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially support using pathlib.Path for static_folder. #3579

Merged
merged 1 commit into from Jul 6, 2020

Conversation

jab
Copy link
Member

@jab jab commented Apr 20, 2020

  • No longer causes AttributeError: 'PosixPath' object has no attribute 'rstrip'.

  • This was broken by e6178fe which was released in 1.1.2.

  • Add a regression test that now passes.

See #3557.

(That issue was repurposed for migrating to pathlib internally, which this PR does not resolve. Merely officially supporting Paths for static_folder need not require that.)

@jab jab mentioned this pull request Apr 20, 2020
@jab jab force-pushed the pathlib-for-static_folder branch 2 times, most recently from 4aac2e0 to cd59606 Compare Apr 20, 2020
@jab jab marked this pull request as draft Apr 20, 2020
@jab jab requested a review from davidism Apr 20, 2020
@jab jab marked this pull request as ready for review Apr 20, 2020
* No longer causes AttributeError: 'PosixPath' object has no
  attribute 'rstrip'.

* This was broken by e6178fe
  which was released in 1.1.2.

* Add a regression test that now passes.

See pallets#3557.
@jab jab force-pushed the pathlib-for-static_folder branch from cd59606 to 7ba35c4 Compare Jul 6, 2020
@jab jab changed the base branch from 1.1.x to master Jul 6, 2020
pgjones
pgjones approved these changes Jul 6, 2020
@jab jab merged commit cf5b1d0 into pallets:master Jul 6, 2020
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants