don't show trace for --help without FLASK_APP #3604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obfusk
force-pushed
the
fix-cli-help-exception
branch
4 times, most recently
from
a844664
to
40c7d2a
Compare
obfusk
force-pushed
the
fix-cli-help-exception
branch
from
40c7d2a
to
3aba77e
Compare
| traceback.print_exc() | ||
| except NoAppException as e: | ||
| # We don't want the help page to break if the app does not exist. | ||
| print("Error:", e, file=sys.stderr) |
There was a problem hiding this comment.
Isn't it useful to have a full traceback?
There was a problem hiding this comment.
In flask --help or flask without args? I'd say no... individual subcommands will still have the traceback AFAIU.
There was a problem hiding this comment.
Oh right – that makes sense (thanks)
davidism
changed the title
|
Thanks for working on this. After looking at how the error messages work right now, I've concluded that this isn't the correct fix. The tracebacks were added in #2208. #2209 (comment) suggests hiding the traceback and showing the message only for |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2741.