Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update /docs/testing.rst based on new tutorial tests #3606

Closed
wants to merge 4 commits into from

Conversation

isdanni
Copy link

@isdanni isdanni commented May 10, 2020

Update the /docs/testing.rst

Update the/docs/testing.rst. Remove the incompatible code snippet like this one since the flaskr application has been rewritten and does not contain a flaskr object.

a. Sections removed from /docs/testing.rst:

  1. The Testing Skeleton;
  2. The First Test;
  3. Logging In and Out;
  4. Test Adding Messages;

b. Replaced with:

  1. The Testing Setup and Fixtures;
  2. Database;
  3. Authentication;
  4. Blog;

c. Added Section:

  • Factory; (The previous version referred to 0.12, which does not contain an app factory, could cause confusions)

Most description is directly taken from /docs/tutorial/tests.rst since @davidism mentioned here that the tutorial is update to date;

Relevant issues: #2831, #3545, and #2833 .
Possible overlaps: #3349 , #3311 .

NOTE: updating the testing docs seems like a long-term job and would take some effort to entirely make the testing docs compatible with the current flask version; I will continue study and update more outdated contents; Meanwhile, any suggestions and help are welcome! :)

@isdanni isdanni changed the title Update the /docs/testing.rst Fix: Update the /docs/testing.rst May 15, 2020
@davidism davidism added the docs label Jun 7, 2020
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
docs/testing.rst Outdated Show resolved Hide resolved
Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
@davidism davidism changed the title Fix: Update the /docs/testing.rst update /docs/testing.rst based on new tutorial tests Jul 28, 2020
@davidism
Copy link
Member

Thanks for working on this. I ended up doing a full rewrite of these docs in #4448.

@davidism davidism closed this Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants