Breaking a ref cycle created by default in Flask() #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjarri
force-pushed
the
break-ref-cycle
branch
from
233880d
to
3d620cf
Compare
jab
reviewed
Sep 23, 2020
There was a problem hiding this comment.
Thanks for the PR! I’m not sure if we’ll end up accepting this change (defer to @davidism), but in the meantime it wouldn’t hurt to add some test coverage. Here’s an example of some test coverage I added to one of my projects to prove my weakrefs are working as intended, in case it’s helpful: https://github.com/jab/bidict/blob/master/tests/properties/test_properties.py#L273
|
Thanks for the pointer, I added a test (shamelessly stole most of it from your project). |
fjarri
force-pushed
the
break-ref-cycle
branch
2 times, most recently
from
c7c7ae7
to
bf156fc
Compare
fjarri
force-pushed
the
break-ref-cycle
branch
from
bf156fc
to
4173f41
Compare
jab
added a commit
to fjarri/flask
that referenced
this pull request
Oct 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3761
Breaks the ref cycle
Flask->view_functions->self.send_static_file->Flaskthat is created in the constructor.