Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update: Clarify got_request_exception signal docs #3883

Merged

Conversation

tonydelanuez
Copy link
Contributor

@tonydelanuez tonydelanuez commented Jan 30, 2021

got_request_exception documentation did not explain that the signal is only sent for unhandled exceptions, not HTTPException or other handled exceptions.

closes #3851

@greyli greyli added the docs label Feb 2, 2021
@davidism davidism force-pushed the clarify-got-request-exception branch 2 times, most recently from cb26b66 to 582bbeb Compare February 2, 2021 04:27
Co-authored-by: David Lord <davidism@gmail.com>
@davidism davidism force-pushed the clarify-got-request-exception branch from 582bbeb to 451c1f8 Compare February 2, 2021 04:28
@davidism
Copy link
Member

davidism commented Feb 2, 2021

The existing section was already bit confusing, so I did a further rewrite based on your changes. It describes that it's sent for unhandled exceptions, and not sent for HTTPExcpetion and handled exceptions. Also rewrote the example to be more interesting, since exceptions are already logged anyway.

@davidism davidism merged commit 15f0fc2 into pallets:master Feb 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raising HTTPException does not cause got_request_exception signal to be emitted
3 participants