Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more work on Scaffold base class #3933

Merged
merged 5 commits into from
Mar 10, 2021
Merged

more work on Scaffold base class #3933

merged 5 commits into from
Mar 10, 2021

Conversation

davidism
Copy link
Member

Moves all of _PackageBoundObject into Scaffold. Some related functions (that were not part of the public API) were also moved from helpers to scaffold.

errorhandler and register_error_handler both used _register_error_handler, which was redundant and didn't match the rest of the decorator/method pairs. errorhandler is now a direct wrapper around register_error_handler.

During the initial refactor to Scaffold, we missed that the various callback data was added with record_once, but the new implementation merged the data on each registration. Now it's only merged on first registration.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 2.0.0 milestone Mar 10, 2021
@davidism davidism merged commit 510c38c into master Mar 10, 2021
@davidism davidism deleted the more-scaffold branch March 10, 2021 19:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant