Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing #3973

Merged
merged 2 commits into from Apr 27, 2021
Merged

Typing #3973

merged 2 commits into from Apr 27, 2021

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Apr 25, 2021

Initial type hints

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

tox.ini Show resolved Hide resolved
requirements/typing.in Outdated Show resolved Hide resolved
This enables type checking in CI and marks the project as typed.
This should make it easier for users to correctly use Flask. The hints
are from Quart.
@davidism davidism merged commit 1a8549d into pallets:master Apr 27, 2021
@pgjones pgjones deleted the typing branch April 27, 2021 14:55
@pgjones
Copy link
Member Author

pgjones commented Apr 27, 2021

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants