Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3 using 2to3 - passes tests with py25-27,py32,pypy #627

Closed
wants to merge 6 commits into from

Conversation

puzzlet
Copy link

@puzzlet puzzlet commented Nov 6, 2012

This branch supports Python 2.5 through 3.2, passes all the tests when used with 2to3 port of Werkzeug and itsdangerous (In Python 3.1, it leaks memory for some reason)

@soulseekah
Copy link
Contributor

It still failed https://travis-ci.org/#!/mitsuhiko/flask/jobs/3077101 couldn't get simplejson. Is there a way to rerun this commit? It seems they had a network issue or something.

@sigmavirus24
Copy link

@soulseekah yeah, unfortunately it seems that Travis has been erroring out for horribly random reasons. @puzzlet should see if there's a way he can kick it. Maybe closing/reopening the pull would work.

@soulseekah
Copy link
Contributor

Well one of the core maintainers with merge privileges would still have to test this themselves anyway.

@sigmavirus24
Copy link

@soulseekah yeah, I was just saying, he needed to do it so they could see that off the bat. Also, @puzzlet could you add python 3.2 to the .travis.yml build matrix? That provides the results that are very relevant to this. Also, if Travis has begun to offer 3.3 yet, that too.

@puzzlet
Copy link
Author

puzzlet commented Nov 7, 2012

@sigmavirus24 Well, with python 3 the test in Travis would fail because Werkzeug and itsdangerous have no support in the upstream yet. Or is there a way to configure Travis to fetch them from the git repositories beforehand?

@sigmavirus24
Copy link

Add a file named requirements.txt with -e git+git://github.com/puzzlet/werkzeug@feature/2to3 for werkzeug and a similar url for itsdangerous. I believe the @ will designate the branch. Also to the .travis.yml add the line:

install: pip install -r requirements.txt --use-mirrors. This way they'll pre-empt the installs performed in setup.py. Of course, @mitsuhiko might not appreciate that, but this will prove that those 3 together allow for a port to python3.

@soulseekah
Copy link
Contributor

Interesting, thank you for your effort @puzzlet

@DasIch
Copy link
Contributor

DasIch commented Jun 19, 2013

We support 3.3 now.

@DasIch DasIch closed this Jun 19, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants