Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jinja2 >= 2.9 Missing Deps? #653

Closed
thatrevguy opened this issue Jan 10, 2017 · 5 comments
Closed

Jinja2 >= 2.9 Missing Deps? #653

thatrevguy opened this issue Jan 10, 2017 · 5 comments

Comments

@thatrevguy
Copy link

thatrevguy commented Jan 10, 2017

Expected Behavior

RPM build should complete successfully.

Actual Behavior

Compiling /home/<user>/rpmbuild/BUILDROOT/<NVRA>/<APP_PATH>/env/lib/python2.7/site-packages/jinja2/asyncfilters.py ...
  File "<APP_PATH>/env/lib/python2.7/site-packages/jinja2/asyncfilters.py", line 7
    async def auto_to_seq(value):
            ^
SyntaxError: invalid syntax

Compiling /home/<user>/rpmbuild/BUILDROOT/<NVRA>/<APP_PATH>/env/lib/python2.7/site-packages/jinja2/asyncsupport.py ...
  File "<APP_PATH>/env/lib/python2.7/site-packages/jinja2/asyncsupport.py", line 22
    async def concat_async(async_gen):

Your Environment

  • Python version: 2.7.5
  • Jinja version: >= 2.9
@ThiefMaster
Copy link
Member

Looks a lot like a duplicate of #643

@thatrevguy
Copy link
Author

Ya looks like so, but with no clear resolution other than a PIP issue ref that has no bearing on RPM build compile. We use RPM for distribution and use compile. Is expectation to skip compile for this package or version lock to 2.8.1?

@ThiefMaster
Copy link
Member

ThiefMaster commented Jan 10, 2017

Can you skip compilation for certain files? These two files are never imported in python<3.6

@thatrevguy
Copy link
Author

Checking if I can skip certain files real quick, we are using setup.py to drive build logic.

@thatrevguy
Copy link
Author

Looks like I can add _python_bytecompile_errors_terminate_build to spec. This seems like a hack however as this will ignore possible legitimate compile errors we'll want the build to fail on...

bob-beck pushed a commit to openbsd/ports that referenced this issue Feb 18, 2018
conditional byte-compile and install asyncfilter.py and asyncsupport.py, as not
imported in python<3.6 (pallets/jinja#653)

ok maintainer
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants