Prevent default filter from throwing UndefinedError #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is used with StrictUndefined.
mitsuhiko
added a commit
that referenced
this pull request
May 19, 2013
Prevent default filter from throwing UndefinedError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default filter currently throws an UndefinedError when environment is using StrictUndefined mode and using the boolean flag for default filter. example:
{{ something|default(somethingelse, true) }}Will throw an UndefinedError when
somethingis undefined.This pull request fixes that and adds a unit test exemplifying the problem.