Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate legacy resolve mode #1393

Merged
merged 1 commit into from
Apr 12, 2021
Merged

deprecate legacy resolve mode #1393

merged 1 commit into from
Apr 12, 2021

Conversation

davidism
Copy link
Member

Changed the metaclass logic to check if the names were defined on the child class instead of comparing the function objects. _fast_resolve_mode was never getting triggered, which suggested comparing the objects wasn't completely reliable anyway. Inlined the resolve_or_missing function into both methods.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism added this to the 3.0.0 milestone Apr 12, 2021
@davidism davidism merged commit 06230b0 into master Apr 12, 2021
@davidism davidism deleted the deprecate-legacy-resolve branch April 12, 2021 06:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove Context._legacy_resolve_mode
1 participant