Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return an aclose-able AsyncGenerator from Template.generate_async #1957

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

return an aclose-able AsyncGenerator from Template.generate_async #1957

wants to merge 3 commits into from

Conversation

graingert
Copy link

@graingert graingert commented Apr 7, 2024 •
edited

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@graingert graingert marked this pull request as ready for review April 7, 2024 17:23
graingert
graingert commented Apr 7, 2024
View reviewed changes
CHANGES.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate_async type annotation does not support .aclose()
1 participant
@graingert