Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continue on search path if ENOTDIR returned when looking for templates #839

Closed
wants to merge 1 commit into from
Closed

Continue on search path if ENOTDIR returned when looking for templates #839

wants to merge 1 commit into from

Conversation

ishakir
Copy link

@ishakir ishakir commented Apr 10, 2018

This became a problem in my build environment where we're running from python packaged into .jar files. The code looks for a path of the form run.jar/templates/my_template.html which returns errno.ENOTDIR breaking out of the whole search loop. This fixes that.

@ishakir
Copy link
Author

ishakir commented Apr 10, 2018

I believe the build failure to be related to existing issues

@ishakir
Copy link
Author

ishakir commented Apr 11, 2018 •
edited

This is a duplicate of the following:

#822

which fixes #821 as well.

I have, however, gone through to check that there are no tests for open_if_exists

@davidism davidism closed this Apr 11, 2018
@ishakir ishakir mentioned this pull request Apr 11, 2018
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ishakir @davidism