Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trove classifier for PyPy support #892

Merged
merged 1 commit into from Aug 30, 2018
Merged

Add trove classifier for PyPy support #892

merged 1 commit into from Aug 30, 2018

Conversation

jdufresne
Copy link
Contributor

Tested during CI since 761da6f.

@davidism
Copy link
Member

davidism commented Aug 30, 2018

Is there a reason beyond "users could technically filter by them in PyPI" to use these? I don't use them in any other projects, in Pallets or otherwise.

Basically, we're not going out of our way to make this a "cpython library" or a "pypy library", besides maybe a small compat entry here or there. So they don't really seem appropriate.

@jdufresne
Copy link
Contributor Author

I find them useful because they allow potential users to know -- at a quick glance -- what Pythons are supported by a library. Sometimes when integrating a library with my own projects, I'll use this information to help decide if it is good for integration.

As the trove classifiers have a consistent form, they are also used by sites and offline scripts to analyze the changes in the Python community. Some examples:

If you don't support PyPy as a platform, then I don't think you should add it. But PyPy is included in CI, so it appears that compatibility is desired. I think adding CPython is only useful in contrast to PyPy so as not to give the impression that the library is PyPy only.

Up to you.

@davidism davidism merged commit 5ecdc80 into pallets:master Aug 30, 2018
@jdufresne jdufresne deleted the trove-pypy branch August 30, 2018 14:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants