Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NULL check after native call to __html__ method #109

Merged
merged 1 commit into from Feb 20, 2019
Merged

Add NULL check after native call to __html__ method #109

merged 1 commit into from Feb 20, 2019

Conversation

@mthuurne
Copy link
Contributor

@mthuurne mthuurne commented Feb 18, 2019

If the method raises an exception, PyObject_CallObject() returns NULL,
but the code didn't check for that, which led to a segfault.

Fixes #108

If the method raises an exception, PyObject_CallObject() returns NULL,
but the code didn't check for that, which led to a segfault.

Fixes #108
@davidism

This comment has been hidden.

@davidism davidism added this to the 1.1.1 milestone Feb 18, 2019
@mthuurne

This comment has been hidden.

@ThiefMaster

This comment has been hidden.

@mthuurne

This comment has been hidden.

@davidism davidism merged commit 1ab4f0a into pallets:master Feb 20, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
davidism added a commit that referenced this pull request Feb 20, 2019
@davidism
Copy link
Member

@davidism davidism commented Feb 20, 2019

Cherry picked to 1.1.x branch: eb9c1d4
Added changelog: d1b3c5a

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants