Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Appveyor script for building Windows wheels #65

Merged
merged 3 commits into from Oct 8, 2017
Merged

Add Appveyor script for building Windows wheels #65

merged 3 commits into from Oct 8, 2017

Conversation

dougthor42
Copy link
Contributor

This adds Appveyor CI for building Windows wheels.

  • PyPy is not built because Appveyor doesn't come with PyPy pre-installed and I didn't want to figure out how to add it.
  • A stub for releasing to GitHub is included but commented out, as it will require the repo maintainer to generate a token and then secure it in Appveyor.
  • Wheel artifacts are made for every build and uploaded to Appveyor. It's out of scope of this PR to auto-upload them to PyPI.
  • Addresses wheels for markupsafe #45, though I'm not sure if this PR actually closes it.

@dougthor42 dougthor42 changed the title Added Appveyor script for building Windows wheels Add Appveyor script for building Windows wheels Feb 13, 2017
ThiefMaster
ThiefMaster reviewed Feb 14, 2017
View reviewed changes
appveyor.yml Outdated
#deploy:
# - provider: GitHub
# auth_token:
# secure: <your encrypted token> # encrypoted github token

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

@dougthor42
Copy link
Contributor Author

@davidism Please review. Having windows wheels will make many people's lives a lot easier.

@davidism
Copy link
Member

davidism commented Apr 27, 2017 •
edited

I'm currently in the middle of going through Flask's backlog before PyCon, and don't have a lot of free time besides that. I'm aware of the PR, you don't need to keep pinging me.

@dougthor42
Copy link
Contributor Author

Sorry about the annoyances! I'm used to contributing to projects that are barely maintained. I'll stop 😄

@davidism davidism mentioned this pull request Jul 19, 2017
Closed
@hugovk hugovk mentioned this pull request Oct 8, 2017
Closed
@davidism davidism self-assigned this Oct 8, 2017
@davidism davidism merged commit ed71095 into pallets:master Oct 8, 2017
@davidism davidism mentioned this pull request Oct 8, 2017
Closed
@dougthor42 dougthor42 deleted the windows-wheels-via-appveyor branch October 10, 2017 23:34
@hugovk hugovk mentioned this pull request Nov 29, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

@hugovk hugovk hugovk approved these changes

Assignees

@davidism davidism

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dougthor42 @davidism @ThiefMaster @hugovk