Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style for sphinx-tabs extension #31

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

greyli
Copy link
Member

@greyli greyli commented Aug 2, 2020

Add style for the new Sphinx extension (sphinx-tabs) introduced in Flask documentation (pallets/flask#3714). This is the original style:

image-20200802130954306

The is the improved style (it may still need to improve):

image-20200802131211668

@return42
Copy link

return42 commented Jan 2, 2021

I would vote against this PR (sorry).

I use pallets in several projects and I like to stay with the defaults from sphinx-tab. This PR replaces the defaults from sphinx-tab what should not be an object of the pallets project, I think.

@davidism davidism merged commit 869ccf5 into pallets:master Apr 13, 2021
@greyli greyli deleted the add-sphinx-tabs-style branch May 12, 2021 03:49
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants