Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.2.0 breaks werkzeug.routing.ValidationError import #2465

Closed
itamarst opened this issue Jul 25, 2022 · 1 comment · Fixed by #2468
Closed

2.2.0 breaks werkzeug.routing.ValidationError import #2465

itamarst opened this issue Jul 25, 2022 · 1 comment · Fixed by #2468
Milestone

Comments

@itamarst
Copy link

(venv-test) $ pip install werkzeug
Collecting werkzeug
  Downloading Werkzeug-2.2.0-py3-none-any.whl (232 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 232.2/232.2 KB 3.5 MB/s eta 0:00:00
Collecting MarkupSafe>=2.1.1
  Using cached MarkupSafe-2.1.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (25 kB)
Installing collected packages: MarkupSafe, werkzeug
Successfully installed MarkupSafe-2.1.1 werkzeug-2.2.0
(venv-test) $ python
Python 3.10.4 (main, Jun 29 2022, 12:14:53) [GCC 11.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from werkzeug.routing import ValidationError
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: cannot import name 'ValidationError' from 'werkzeug.routing' (/tmp/venv-test/lib/python3.10/site-packages/werkzeug/routing/__init__.py)

This is a documented API for 2.2, e.g. https://werkzeug.palletsprojects.com/en/2.2.x/routing/#custom-converters example code.

Environment:

  • Python version: 3.10
  • Werkzeug version: 2.2.0
@davidism
Copy link
Member

Missed this one when we refactored to split into submodules.

@davidism davidism added this to the 2.2.1 milestone Jul 25, 2022
@davidism davidism linked a pull request Jul 25, 2022 that will close this issue
6 tasks
crwood added a commit to gridsync/gridsync that referenced this issue Jul 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants