Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProxyMiddleware with query string #1252

Merged
merged 1 commit into from Feb 23, 2018
Merged

Fix ProxyMiddleware with query string #1252

merged 1 commit into from Feb 23, 2018

Conversation

lepture
Copy link
Contributor

@lepture lepture commented Feb 13, 2018

ProxyMiddleware should contain query string when sending the request.

@lepture
Copy link
Contributor Author

lepture commented Feb 13, 2018

The build error is caused by sphinx.

cc @mitsuhiko

@lepture
Copy link
Contributor Author

lepture commented Feb 23, 2018

test case failed due to testing cache.

@davidism
Copy link
Member

Reran the tests, everything looks good.

@davidism davidism merged commit ea0ed8f into master Feb 23, 2018
@davidism davidism deleted the patch-proxy branch February 23, 2018 14:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mitsuhiko mitsuhiko Awaiting requested review from mitsuhiko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lepture @davidism