Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whitespace %20 in uri_to_iri. #1363

Closed
wants to merge 2 commits into from
Closed

Fix whitespace %20 in uri_to_iri. #1363

wants to merge 2 commits into from

Conversation

lepture
Copy link
Contributor

@lepture lepture commented Sep 15, 2018

Fix #1356

@davidism davidism mentioned this pull request Sep 17, 2018
Closed
davidism
davidism approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@davidism davidism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add a changelog.

@lepture
Copy link
Contributor Author

lepture commented Sep 18, 2018

No. I think uri_to_iri has no problem. But the Request.url has a problem, the url should be in URI instead of IRI according to the name.

@lepture lepture closed this Sep 18, 2018
@davidism davidism reopened this Sep 18, 2018
@lepture lepture added this to the 0.15 milestone Dec 6, 2018
lepture added a commit that referenced this pull request Dec 6, 2018
@lepture
Add changelog for #1363 uri_to_iri
fc5b755
davidism
davidism reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@davidism davidism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing the code, it seems like while this solves the specific issues with spaces, there are many more characters that are not handled correctly. I think a bigger change may be needed.

@lepture
Copy link
Contributor Author

lepture commented Jan 10, 2019

Yeah. I think so too.

@davidism
Copy link
Member

Closing this, working on a bigger change.

@davidism davidism closed this Jan 10, 2019
@davidism davidism deleted the issue-1356 branch January 20, 2019 16:12
@spacemansteve spacemansteve mentioned this pull request Nov 22, 2019
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidism davidism davidism approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

Successfully merging this pull request may close these issues.

uri_to_iri incorrectly handles %20
2 participants
@lepture @davidism