switch to cryptography library #1555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
May 22, 2019
|
Fixed. Also I noticed that the half of my commit was not committed (reason why the tests failed). |
pyOpenSSL is only a wrapper around cryptography now. It recommends using cryptography directly for our use case.
davidism
force-pushed
the
feature/switch_to_cryptography
branch
from
495426f
to
84c98f2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyOpenSSL is now a wrapper around the cryptography library. So why using a wrapper?
This PR switches to the pure cryptography library.
This should not break anything (dependency-wise) as pyOpenSSL depends for versions on cryptography.
Note: there could be some small changes (different company name in the stub certificate).