Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to cryptography library #1555

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
3 participants
@devkral
Copy link
Contributor

commented May 22, 2019

pyOpenSSL is now a wrapper around the cryptography library. So why using a wrapper?
This PR switches to the pure cryptography library.
This should not break anything (dependency-wise) as pyOpenSSL depends for versions on cryptography.

Note: there could be some small changes (different company name in the stub certificate).

Show resolved Hide resolved src/werkzeug/serving.py Outdated
@devkral

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

Fixed. Also I noticed that the half of my commit was not committed (reason why the tests failed).

@davidism davidism added this to the 1.0.0 milestone Jul 12, 2019

use cryptography instead of pyOpenSSL
pyOpenSSL is only a wrapper around cryptography now. It recommends
using cryptography directly for our use case.

@davidism davidism force-pushed the devkral:feature/switch_to_cryptography branch from 495426f to 84c98f2 Jul 12, 2019

@davidism davidism merged commit 71cf990 into pallets:master Jul 12, 2019

11 checks passed

Tests Build #20190712.14 succeeded
Details
Tests (Job Docs) Job Docs succeeded
Details
Tests (Job PyPy 3 Linux) Job PyPy 3 Linux succeeded
Details
Tests (Job Python 2.7 Linux) Job Python 2.7 Linux succeeded
Details
Tests (Job Python 2.7 Windows) Job Python 2.7 Windows succeeded
Details
Tests (Job Python 3.5 Linux) Job Python 3.5 Linux succeeded
Details
Tests (Job Python 3.6 Linux) Job Python 3.6 Linux succeeded
Details
Tests (Job Python 3.7 Linux) Job Python 3.7 Linux succeeded
Details
Tests (Job Python 3.7 Mac) Job Python 3.7 Mac succeeded
Details
Tests (Job Python 3.7 Windows) Job Python 3.7 Windows succeeded
Details
Tests (Job Style) Job Style succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.