Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to cryptography library #1555

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@devkral
Copy link
Contributor

@devkral devkral commented May 22, 2019

pyOpenSSL is now a wrapper around the cryptography library. So why using a wrapper?
This PR switches to the pure cryptography library.
This should not break anything (dependency-wise) as pyOpenSSL depends for versions on cryptography.

Note: there could be some small changes (different company name in the stub certificate).

src/werkzeug/serving.py Outdated Show resolved Hide resolved
@devkral
Copy link
Contributor Author

@devkral devkral commented May 22, 2019

Fixed. Also I noticed that the half of my commit was not committed (reason why the tests failed).

@davidism davidism added this to the 1.0.0 milestone Jul 12, 2019
pyOpenSSL is only a wrapper around cryptography now. It recommends
using cryptography directly for our use case.
@davidism davidism force-pushed the feature/switch_to_cryptography branch from 495426f to 84c98f2 Jul 12, 2019
@davidism davidism merged commit 71cf990 into pallets:master Jul 12, 2019
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants