Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reloader ignores file open events #2604

Merged
merged 1 commit into from Mar 3, 2023

Conversation

jdimmerman
Copy link
Contributor

Ignore file opened events in the Watchdog Reloader.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@jdimmerman jdimmerman changed the base branch from main to 2.2.x March 1, 2023 00:44
CONTRIBUTING.rst Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
src/werkzeug/_reloader.py Outdated Show resolved Hide resolved
src/werkzeug/_reloader.py Show resolved Hide resolved
tests/test_serving.py Outdated Show resolved Hide resolved
@davidism davidism changed the title 2603 reloader ignore open reloader ignores file open events Mar 1, 2023
@jdimmerman
Copy link
Contributor Author

@davidism thanks for the feedback! I ended up updating the requirements files in order to update to/past the changed version of watchdog. Please let me know if you have any other feedback

@davidism davidism changed the base branch from 2.2.x to main March 3, 2023 17:49
@davidism davidism added this to the 2.3.0 milestone Mar 3, 2023
@davidism davidism merged commit fae889d into pallets:main Mar 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchdogReloaderLoop reloading on every http request due to change in watchdog
2 participants