Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the PathConverter (and descendants) to be non part isolating #2784

Merged
merged 1 commit into from Sep 30, 2023

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Sep 30, 2023

This is likely to be the expected for anything that is or extends the PathConverter and by adding it explicitly I hope it will cause less confusion, as seen in a recent issue 2783.

Note the PathConverter was already non part isolating due to the BaseConverter check.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

This is likely to be the expected for anything that is or extends the
PathConverter and by adding it explicitly I hope it will cause less
confusion, as seen in a recent issue 2783.

Note the PathConverter was already non part isolating due to the
BaseConverter check.
@pgjones pgjones merged commit 6427542 into pallets:main Sep 30, 2023
11 checks passed
@pgjones pgjones deleted the path branch September 30, 2023 13:52
@pgjones pgjones added this to the 3.0.0 milestone Sep 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant