Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if the converter arguments cannot be parsed #2864

Merged
merged 1 commit into from Mar 19, 2024

Conversation

pgjones
Copy link
Member

@pgjones pgjones commented Mar 9, 2024

This could happen for example with min=0;max=500 as the ; is not a word character everything before it is ignored in the regex during the finditer call. This then lefts the user confused as the min=0; was silently ignored.

fixes #2822

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

This could happen for example with `min=0;max=500` as the `;` is not a
word character everything before it is ignored in the regex during the
finditer call. This then lefts the user confused as the `min=0;` was
silently ignored.
@pgjones pgjones merged commit 5741398 into pallets:3.0.x Mar 19, 2024
11 checks passed
@pgjones pgjones deleted the converter branch March 19, 2024 21:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant