Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.x #2872

Closed
wants to merge 9 commits into from
Closed

3.0.x #2872

wants to merge 9 commits into from

Commits on Mar 3, 2024

  1. Use more precise type for formparser.MultiPartParser.parse return

    Without this change, `pyright` with `typeCheckingMode` set to `strict` reports:
    
    ```
    error: Type of "fields" is partially unknown
        Type of "fields" is "MultiDict[Unknown, Unknown]" (reportUnknownVariableType)
    ```
    
    when I use this method.
    adamtheturtle authored and pgjones committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    70ad4d6 View commit details
    Browse the repository at this point in the history
  2. Make the exception tests more robust

    This should ensure that the tests work with Pytest 8 onwards. The
    issue appears to be that __subclasses__ "returns a list of all those
    references still alive." which could include the RequestRedirect. If
    it does include RequestRedirect the tests will fail as it requires an
    argument to be constructed. Note this test is not meant for
    RequestRedirect.
    pgjones committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4e5bdca View commit details
    Browse the repository at this point in the history
  3. Fix: Use issubclass instead of isinstance

    Bug described at #2831
    jace authored and pgjones committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    7ab3823 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4c09d1b View commit details
    Browse the repository at this point in the history
  5. Handle TypeError in TypeConversionDict

    TypeErrors are now handled in the same manner as ValueErrors.
    
    fixes #2842
    Sympatron authored and pgjones committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    f516c40 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Fix issue with repeated-slash requests redirecting

    Previously if a request had repeated slashes it could match a single
    slash route and hence return a redirect response even if merge_slashes
    was False.
    
    Additionally setting the merge_slashes attribute of the map after
    initialisation had no affect, compounding this problem.
    pgjones committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    0b47237 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Raise an error if the converter arguments cannot be parsed

    This could happen for example with `min=0;max=500` as the `;` is not a
    word character everything before it is ignored in the regex during the
    finditer call. This then lefts the user confused as the `min=0;` was
    silently ignored.
    pgjones committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    5741398 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Bump the slsa-github-generator action version

    As this solves a publishing error.
    pgjones committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    ad703fd View commit details
    Browse the repository at this point in the history
  2. Release version 3.0.2

    pgjones committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    d70dcea View commit details
    Browse the repository at this point in the history