Abstract run_in_docker to a utility function #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow plugins to execute commands in docker during setup. We need this to reliably detect which dbt version a given project is using.
jakeberesford-palmetto
requested review from
emilypastewka,
a user and
david-jy-kim
and removed request for
a team
This is useful when we need to do something with the output from Docker programmatically.
|
No merge because I'm still testing the capture output stuff to make sure it doesn't break anything. Should be safe. |
This allows us to run commands in docker without outputting the command. Maybe a little shady, but makes for a slicker DX in some cases.
|
I've been running this change for a few days now without any issues. Should be good-to-go! |
norton120
approved these changes
Sep 27, 2023
jakeberesford-palmetto
merged commit a2c4fe6
into
palmetto:develop
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Before submitting your PR, please review the following checklist:
palm test)palm lint) has passed locally and any fixes were made for failuresBreaking changes
What does this implement/fix? Explain your changes.
This will allow plugins to execute commands in docker during setup. We need this to reliably detect which dbt version a given project is using.
There is no functional change here, just a new abstraction to enable a change elsewhere.
Does this close any currently open issues?
Not directly, it's a step towards being able to resolve an open issue in palm-dbt
Where has this been tested?
MacOS + Docker v24
Tested with a dbt project using palm-dbt
Tested with a non-dbt project.