-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't resolve '@theme/Unlisted' after update to Docusaurus 3.5.0 #911
Comments
Hi @Preston-Landers, seems to be an undocumented breaking change introduced here: https://github.com/facebook/docusaurus/pull/10376/files |
I started working on a PR for this issue. Upon upgrading the Docusaurus version, i tried two different approaches. 1st. I tried to swap the import path and continue to use the Doing both of these approaches leaves me with the following error:
If i make the I'm still fairly new to React in general, so I haven't been able to discover what the root cause of the issue its. I'll continue to mess around in hopes that I can solve the issue, but a more experienced Developer might be able to make light work of this. :) Edit: Seems to be coming from the |
It's a fairly simple fix but may require breaking backward compatibility with prior releases. |
If this is a breaking change in docusaurus should an issue be opened there for them to fix? |
You could, but I doubt it would lead to a fix. Over the years, we've come to expect breaking changes to land every so often, as the semantic versioning doesn't apply to some internals. That said, I looked into it earlier today and it seems the fix will not be trivial after all. The bigger question is, if the solution does in fact break backward compatibility should we bump our plugin to v4? |
Will there be a fix rolled out for this? |
Hi everyone, I opened a PR that adds support for Docusaurus 3.5.0+. As mentioned before, this change requires breaking backward compatibility. |
nice! thanks for the fix. any timeline for when you think you will push this release to npm? |
I just tested the latest canary release |
Stable release v4.0.0 contains the fix for this |
Confirmed working for me now (with Docusaurus v3.5.2). Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
@sserrata I attempted to upgrade to docusaurus 3.5.2 and version 4.0.1 of this plugin, and got errors. I found that some 3.4.0 docusaurus packages are still installed, I believe due to the range on
^3.5.0 , to ensure that an older, incompatible version of @docusaurus/theme-common is not used. I'll open a PR shortly.
|
Describe the bug
First, thanks for the great plugin. After updating to Docusaurus 3.5.0, the build fails with:
Module not found: Error: Can't resolve '@theme/Unlisted' in '/home/planders/src/jx/jx-api-docs/node_modules/docusaurus-theme-openapi-docs/lib/theme/ApiItem/Layout'
Expected behavior
Compilation should continue to work.
Current behavior
Updated to Docusaurus 3.5.0 (from 3.4.0) with the following command:
Then compilation fails with:
Steps to reproduce
yarn build
or equivalent to see the build failure.Your Environment
The text was updated successfully, but these errors were encountered: